Partner/bondingadmin-install
12
0
Fork 0
Code Pull Requests Packages Projects Releases Activity

DEV-5029: Remove iptable and firewall reference from script. #4

Merged
jfunk merged 3 commits from DEV-5029-remove-iptables-and-firewall-check-from-migrate-script into master 2023-07-24 08:33:13 -03:00
Conversation 2 Commits 3 Files Changed 1 +7 -26
manthan commented 2023-07-19 16:47:53 -03:00
Owner
Copy Link
No description provided.
manthan added 1 commit 2023-07-19 16:47:54 -03:00
jfunk requested changes 2023-07-20 08:27:03 -03:00
migrate Outdated
@ -571,10 +560,7 @@ function action_target_post() {
if -f /usr/sbin/bondingadmin-nftables ; then
echo -e "Restarting nftables service"
systemctl restart bondingadmin-nftables
else
jfunk commented 2023-07-20 08:27:00 -03:00
Owner
Copy Link

Same here.

Same here.
manthan marked this conversation as resolved
migrate
@ -195,4 +195,2 @@
else
known_ips=/etc/firewall.d/known_ips
target_ip_present=false
target_ip=$(get_var target_ip)
jfunk commented 2023-07-20 08:26:47 -03:00
Owner
Copy Link

We don't need this else clause at all now. We can skip the if entirely since the host will always be nftables now.

We don't need this else clause at all now. We can skip the if entirely since the host will always be nftables now.
manthan marked this conversation as resolved
manthan added 1 commit 2023-07-20 11:12:17 -03:00
jfunk requested changes 2023-07-21 07:08:34 -03:00
migrate Outdated
@ -192,19 +192,6 @@ function check_source() {
echo "ip saddr $(get_var target_ip) accept" > $nft_file
bondingadmin-nftables start
fi
else
jfunk commented 2023-07-21 07:08:32 -03:00
Owner
Copy Link

Also the if which bondingadmin-nftables >/dev/null ; then and always do the stuff inside that clause since that's always the case now.

Also the `if which bondingadmin-nftables >/dev/null ; then` and always do the stuff inside that clause since that's always the case now.
manthan marked this conversation as resolved
manthan added 1 commit 2023-07-21 11:36:09 -03:00
jfunk merged commit ce3d75113e into master 2023-07-24 08:33:13 -03:00
jfunk deleted branch DEV-5029-remove-iptables-and-firewall-check-from-migrate-script 2023-07-24 08:33:13 -03:00
Sign in to join this conversation.
Reviewers
No Reviewers
jfunk
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
alan bijan foundry goran grace graeme jfunk jira josh maddie manthan philip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Partner/bondingadmin-install#4
No description provided.
Delete Branch "DEV-5029-remove-iptables-and-firewall-check-from-migrate-script"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?