e986e49e66
Regression in 76b993a117b61c41584e95149a67d8a1e9f49dd1. Thanks Claude Paroz for the report and Carlton Gibson for reviews. Backport of 82a88d2f48e13ef5d472741d5ed1c183230cfe4c from master
243 lines
10 KiB
Python
243 lines
10 KiB
Python
import uuid
|
|
|
|
from django.core.exceptions import ImproperlyConfigured
|
|
from django.test import SimpleTestCase
|
|
from django.test.utils import override_settings
|
|
from django.urls import Resolver404, path, resolve, reverse
|
|
|
|
from .converters import DynamicConverter
|
|
from .views import empty_view
|
|
|
|
included_kwargs = {'base': b'hello', 'value': b'world'}
|
|
converter_test_data = (
|
|
# ('url', ('url_name', 'app_name', {kwargs})),
|
|
# aGVsbG8= is 'hello' encoded in base64.
|
|
('/base64/aGVsbG8=/', ('base64', '', {'value': b'hello'})),
|
|
('/base64/aGVsbG8=/subpatterns/d29ybGQ=/', ('subpattern-base64', '', included_kwargs)),
|
|
('/base64/aGVsbG8=/namespaced/d29ybGQ=/', ('subpattern-base64', 'namespaced-base64', included_kwargs)),
|
|
)
|
|
|
|
|
|
@override_settings(ROOT_URLCONF='urlpatterns.path_urls')
|
|
class SimplifiedURLTests(SimpleTestCase):
|
|
|
|
def test_path_lookup_without_parameters(self):
|
|
match = resolve('/articles/2003/')
|
|
self.assertEqual(match.url_name, 'articles-2003')
|
|
self.assertEqual(match.args, ())
|
|
self.assertEqual(match.kwargs, {})
|
|
self.assertEqual(match.route, 'articles/2003/')
|
|
|
|
def test_path_lookup_with_typed_parameters(self):
|
|
match = resolve('/articles/2015/')
|
|
self.assertEqual(match.url_name, 'articles-year')
|
|
self.assertEqual(match.args, ())
|
|
self.assertEqual(match.kwargs, {'year': 2015})
|
|
self.assertEqual(match.route, 'articles/<int:year>/')
|
|
|
|
def test_path_lookup_with_multiple_parameters(self):
|
|
match = resolve('/articles/2015/04/12/')
|
|
self.assertEqual(match.url_name, 'articles-year-month-day')
|
|
self.assertEqual(match.args, ())
|
|
self.assertEqual(match.kwargs, {'year': 2015, 'month': 4, 'day': 12})
|
|
self.assertEqual(match.route, 'articles/<int:year>/<int:month>/<int:day>/')
|
|
|
|
def test_two_variable_at_start_of_path_pattern(self):
|
|
match = resolve('/en/foo/')
|
|
self.assertEqual(match.url_name, 'lang-and-path')
|
|
self.assertEqual(match.kwargs, {'lang': 'en', 'url': 'foo'})
|
|
self.assertEqual(match.route, '<lang>/<path:url>/')
|
|
|
|
def test_re_path(self):
|
|
match = resolve('/regex/1/')
|
|
self.assertEqual(match.url_name, 'regex')
|
|
self.assertEqual(match.kwargs, {'pk': '1'})
|
|
self.assertEqual(match.route, '^regex/(?P<pk>[0-9]+)/$')
|
|
|
|
def test_re_path_with_optional_parameter(self):
|
|
for url, kwargs in (
|
|
('/regex_optional/1/2/', {'arg1': '1', 'arg2': '2'}),
|
|
('/regex_optional/1/', {'arg1': '1'}),
|
|
):
|
|
with self.subTest(url=url):
|
|
match = resolve(url)
|
|
self.assertEqual(match.url_name, 'regex_optional')
|
|
self.assertEqual(match.kwargs, kwargs)
|
|
self.assertEqual(
|
|
match.route,
|
|
r'^regex_optional/(?P<arg1>\d+)/(?:(?P<arg2>\d+)/)?',
|
|
)
|
|
|
|
def test_re_path_with_missing_optional_parameter(self):
|
|
match = resolve('/regex_only_optional/')
|
|
self.assertEqual(match.url_name, 'regex_only_optional')
|
|
self.assertEqual(match.kwargs, {})
|
|
self.assertEqual(match.args, ())
|
|
self.assertEqual(
|
|
match.route,
|
|
r'^regex_only_optional/(?:(?P<arg1>\d+)/)?',
|
|
)
|
|
|
|
def test_path_lookup_with_inclusion(self):
|
|
match = resolve('/included_urls/extra/something/')
|
|
self.assertEqual(match.url_name, 'inner-extra')
|
|
self.assertEqual(match.route, 'included_urls/extra/<extra>/')
|
|
|
|
def test_path_lookup_with_empty_string_inclusion(self):
|
|
match = resolve('/more/99/')
|
|
self.assertEqual(match.url_name, 'inner-more')
|
|
self.assertEqual(match.route, r'^more/(?P<extra>\w+)/$')
|
|
|
|
def test_path_lookup_with_double_inclusion(self):
|
|
match = resolve('/included_urls/more/some_value/')
|
|
self.assertEqual(match.url_name, 'inner-more')
|
|
self.assertEqual(match.route, r'included_urls/more/(?P<extra>\w+)/$')
|
|
|
|
def test_path_reverse_without_parameter(self):
|
|
url = reverse('articles-2003')
|
|
self.assertEqual(url, '/articles/2003/')
|
|
|
|
def test_path_reverse_with_parameter(self):
|
|
url = reverse('articles-year-month-day', kwargs={'year': 2015, 'month': 4, 'day': 12})
|
|
self.assertEqual(url, '/articles/2015/4/12/')
|
|
|
|
@override_settings(ROOT_URLCONF='urlpatterns.path_base64_urls')
|
|
def test_converter_resolve(self):
|
|
for url, (url_name, app_name, kwargs) in converter_test_data:
|
|
with self.subTest(url=url):
|
|
match = resolve(url)
|
|
self.assertEqual(match.url_name, url_name)
|
|
self.assertEqual(match.app_name, app_name)
|
|
self.assertEqual(match.kwargs, kwargs)
|
|
|
|
@override_settings(ROOT_URLCONF='urlpatterns.path_base64_urls')
|
|
def test_converter_reverse(self):
|
|
for expected, (url_name, app_name, kwargs) in converter_test_data:
|
|
if app_name:
|
|
url_name = '%s:%s' % (app_name, url_name)
|
|
with self.subTest(url=url_name):
|
|
url = reverse(url_name, kwargs=kwargs)
|
|
self.assertEqual(url, expected)
|
|
|
|
@override_settings(ROOT_URLCONF='urlpatterns.path_base64_urls')
|
|
def test_converter_reverse_with_second_layer_instance_namespace(self):
|
|
kwargs = included_kwargs.copy()
|
|
kwargs['last_value'] = b'world'
|
|
url = reverse('instance-ns-base64:subsubpattern-base64', kwargs=kwargs)
|
|
self.assertEqual(url, '/base64/aGVsbG8=/subpatterns/d29ybGQ=/d29ybGQ=/')
|
|
|
|
def test_path_inclusion_is_matchable(self):
|
|
match = resolve('/included_urls/extra/something/')
|
|
self.assertEqual(match.url_name, 'inner-extra')
|
|
self.assertEqual(match.kwargs, {'extra': 'something'})
|
|
|
|
def test_path_inclusion_is_reversible(self):
|
|
url = reverse('inner-extra', kwargs={'extra': 'something'})
|
|
self.assertEqual(url, '/included_urls/extra/something/')
|
|
|
|
def test_invalid_converter(self):
|
|
msg = "URL route 'foo/<nonexistent:var>/' uses invalid converter 'nonexistent'."
|
|
with self.assertRaisesMessage(ImproperlyConfigured, msg):
|
|
path('foo/<nonexistent:var>/', empty_view)
|
|
|
|
def test_space_in_route(self):
|
|
msg = "URL route 'space/<int: num>' cannot contain whitespace."
|
|
with self.assertRaisesMessage(ImproperlyConfigured, msg):
|
|
path('space/<int: num>', empty_view)
|
|
|
|
|
|
@override_settings(ROOT_URLCONF='urlpatterns.converter_urls')
|
|
class ConverterTests(SimpleTestCase):
|
|
|
|
def test_matching_urls(self):
|
|
def no_converter(x):
|
|
return x
|
|
|
|
test_data = (
|
|
('int', {'0', '1', '01', 1234567890}, int),
|
|
('str', {'abcxyz'}, no_converter),
|
|
('path', {'allows.ANY*characters'}, no_converter),
|
|
('slug', {'abcxyz-ABCXYZ_01234567890'}, no_converter),
|
|
('uuid', {'39da9369-838e-4750-91a5-f7805cd82839'}, uuid.UUID),
|
|
)
|
|
for url_name, url_suffixes, converter in test_data:
|
|
for url_suffix in url_suffixes:
|
|
url = '/%s/%s/' % (url_name, url_suffix)
|
|
with self.subTest(url=url):
|
|
match = resolve(url)
|
|
self.assertEqual(match.url_name, url_name)
|
|
self.assertEqual(match.kwargs, {url_name: converter(url_suffix)})
|
|
# reverse() works with string parameters.
|
|
string_kwargs = {url_name: url_suffix}
|
|
self.assertEqual(reverse(url_name, kwargs=string_kwargs), url)
|
|
# reverse() also works with native types (int, UUID, etc.).
|
|
if converter is not no_converter:
|
|
# The converted value might be different for int (a
|
|
# leading zero is lost in the conversion).
|
|
converted_value = match.kwargs[url_name]
|
|
converted_url = '/%s/%s/' % (url_name, converted_value)
|
|
self.assertEqual(reverse(url_name, kwargs={url_name: converted_value}), converted_url)
|
|
|
|
def test_nonmatching_urls(self):
|
|
test_data = (
|
|
('int', {'-1', 'letters'}),
|
|
('str', {'', '/'}),
|
|
('path', {''}),
|
|
('slug', {'', 'stars*notallowed'}),
|
|
('uuid', {
|
|
'',
|
|
'9da9369-838e-4750-91a5-f7805cd82839',
|
|
'39da9369-838-4750-91a5-f7805cd82839',
|
|
'39da9369-838e-475-91a5-f7805cd82839',
|
|
'39da9369-838e-4750-91a-f7805cd82839',
|
|
'39da9369-838e-4750-91a5-f7805cd8283',
|
|
}),
|
|
)
|
|
for url_name, url_suffixes in test_data:
|
|
for url_suffix in url_suffixes:
|
|
url = '/%s/%s/' % (url_name, url_suffix)
|
|
with self.subTest(url=url), self.assertRaises(Resolver404):
|
|
resolve(url)
|
|
|
|
|
|
class ParameterRestrictionTests(SimpleTestCase):
|
|
def test_non_identifier_parameter_name_causes_exception(self):
|
|
msg = (
|
|
"URL route 'hello/<int:1>/' uses parameter name '1' which isn't "
|
|
"a valid Python identifier."
|
|
)
|
|
with self.assertRaisesMessage(ImproperlyConfigured, msg):
|
|
path(r'hello/<int:1>/', lambda r: None)
|
|
|
|
def test_allows_non_ascii_but_valid_identifiers(self):
|
|
# \u0394 is "GREEK CAPITAL LETTER DELTA", a valid identifier.
|
|
p = path('hello/<str:\u0394>/', lambda r: None)
|
|
match = p.resolve('hello/1/')
|
|
self.assertEqual(match.kwargs, {'\u0394': '1'})
|
|
|
|
|
|
@override_settings(ROOT_URLCONF='urlpatterns.path_dynamic_urls')
|
|
class ConversionExceptionTests(SimpleTestCase):
|
|
"""How are errors in Converter.to_python() and to_url() handled?"""
|
|
|
|
def test_resolve_value_error_means_no_match(self):
|
|
@DynamicConverter.register_to_python
|
|
def raises_value_error(value):
|
|
raise ValueError()
|
|
with self.assertRaises(Resolver404):
|
|
resolve('/dynamic/abc/')
|
|
|
|
def test_resolve_type_error_propagates(self):
|
|
@DynamicConverter.register_to_python
|
|
def raises_type_error(value):
|
|
raise TypeError('This type error propagates.')
|
|
with self.assertRaisesMessage(TypeError, 'This type error propagates.'):
|
|
resolve('/dynamic/abc/')
|
|
|
|
def test_reverse_value_error_propagates(self):
|
|
@DynamicConverter.register_to_url
|
|
def raises_value_error(value):
|
|
raise ValueError('This value error propagates.')
|
|
with self.assertRaisesMessage(ValueError, 'This value error propagates.'):
|
|
reverse('dynamic', kwargs={'value': object()})
|