473c526b1b
Regression in 4f5b58f5cd3c57fee9972ab074f8dc6895d8f387. Thanks Florian Apolloner for the report and helping with tests. Backport of 1f8382d34d54061eddc41df6994e20ee38c60907 from master.
418 lines
14 KiB
Python
418 lines
14 KiB
Python
from __future__ import unicode_literals
|
|
|
|
import datetime
|
|
import uuid
|
|
from decimal import Decimal
|
|
|
|
from django.core import exceptions, serializers
|
|
from django.core.serializers.json import DjangoJSONEncoder
|
|
from django.db import connection
|
|
from django.db.models import F
|
|
from django.db.models.expressions import RawSQL
|
|
from django.db.models.functions import Cast
|
|
from django.forms import CharField, Form, widgets
|
|
from django.test import skipUnlessDBFeature
|
|
from django.test.utils import CaptureQueriesContext
|
|
from django.utils.html import escape
|
|
|
|
from . import PostgreSQLTestCase
|
|
from .models import JSONModel
|
|
|
|
try:
|
|
from django.contrib.postgres import forms
|
|
from django.contrib.postgres.fields import JSONField
|
|
from django.contrib.postgres.fields.jsonb import KeyTransform
|
|
except ImportError:
|
|
pass
|
|
|
|
|
|
@skipUnlessDBFeature('has_jsonb_datatype')
|
|
class TestSaveLoad(PostgreSQLTestCase):
|
|
def test_null(self):
|
|
instance = JSONModel()
|
|
instance.save()
|
|
loaded = JSONModel.objects.get()
|
|
self.assertIsNone(loaded.field)
|
|
|
|
def test_empty_object(self):
|
|
instance = JSONModel(field={})
|
|
instance.save()
|
|
loaded = JSONModel.objects.get()
|
|
self.assertEqual(loaded.field, {})
|
|
|
|
def test_empty_list(self):
|
|
instance = JSONModel(field=[])
|
|
instance.save()
|
|
loaded = JSONModel.objects.get()
|
|
self.assertEqual(loaded.field, [])
|
|
|
|
def test_boolean(self):
|
|
instance = JSONModel(field=True)
|
|
instance.save()
|
|
loaded = JSONModel.objects.get()
|
|
self.assertIs(loaded.field, True)
|
|
|
|
def test_string(self):
|
|
instance = JSONModel(field='why?')
|
|
instance.save()
|
|
loaded = JSONModel.objects.get()
|
|
self.assertEqual(loaded.field, 'why?')
|
|
|
|
def test_number(self):
|
|
instance = JSONModel(field=1)
|
|
instance.save()
|
|
loaded = JSONModel.objects.get()
|
|
self.assertEqual(loaded.field, 1)
|
|
|
|
def test_realistic_object(self):
|
|
obj = {
|
|
'a': 'b',
|
|
'c': 1,
|
|
'd': ['e', {'f': 'g'}],
|
|
'h': True,
|
|
'i': False,
|
|
'j': None,
|
|
}
|
|
instance = JSONModel(field=obj)
|
|
instance.save()
|
|
loaded = JSONModel.objects.get()
|
|
self.assertEqual(loaded.field, obj)
|
|
|
|
def test_custom_encoding(self):
|
|
"""
|
|
JSONModel.field_custom has a custom DjangoJSONEncoder.
|
|
"""
|
|
some_uuid = uuid.uuid4()
|
|
obj_before = {
|
|
'date': datetime.date(2016, 8, 12),
|
|
'datetime': datetime.datetime(2016, 8, 12, 13, 44, 47, 575981),
|
|
'decimal': Decimal('10.54'),
|
|
'uuid': some_uuid,
|
|
}
|
|
obj_after = {
|
|
'date': '2016-08-12',
|
|
'datetime': '2016-08-12T13:44:47.575',
|
|
'decimal': '10.54',
|
|
'uuid': str(some_uuid),
|
|
}
|
|
JSONModel.objects.create(field_custom=obj_before)
|
|
loaded = JSONModel.objects.get()
|
|
self.assertEqual(loaded.field_custom, obj_after)
|
|
|
|
|
|
@skipUnlessDBFeature('has_jsonb_datatype')
|
|
class TestQuerying(PostgreSQLTestCase):
|
|
@classmethod
|
|
def setUpTestData(cls):
|
|
cls.objs = [
|
|
JSONModel.objects.create(field=None),
|
|
JSONModel.objects.create(field=True),
|
|
JSONModel.objects.create(field=False),
|
|
JSONModel.objects.create(field='yes'),
|
|
JSONModel.objects.create(field=7),
|
|
JSONModel.objects.create(field=[]),
|
|
JSONModel.objects.create(field={}),
|
|
JSONModel.objects.create(field={
|
|
'a': 'b',
|
|
'c': 1,
|
|
}),
|
|
JSONModel.objects.create(field={
|
|
'a': 'b',
|
|
'c': 1,
|
|
'd': ['e', {'f': 'g'}],
|
|
'h': True,
|
|
'i': False,
|
|
'j': None,
|
|
'k': {'l': 'm'},
|
|
}),
|
|
JSONModel.objects.create(field=[1, [2]]),
|
|
JSONModel.objects.create(field={
|
|
'k': True,
|
|
'l': False,
|
|
}),
|
|
JSONModel.objects.create(field={'foo': 'bar'}),
|
|
]
|
|
|
|
def test_exact(self):
|
|
self.assertSequenceEqual(
|
|
JSONModel.objects.filter(field__exact={}),
|
|
[self.objs[6]]
|
|
)
|
|
|
|
def test_exact_complex(self):
|
|
self.assertSequenceEqual(
|
|
JSONModel.objects.filter(field__exact={'a': 'b', 'c': 1}),
|
|
[self.objs[7]]
|
|
)
|
|
|
|
def test_isnull(self):
|
|
self.assertSequenceEqual(
|
|
JSONModel.objects.filter(field__isnull=True),
|
|
[self.objs[0]]
|
|
)
|
|
|
|
def test_key_transform_raw_expression(self):
|
|
expr = RawSQL('%s::jsonb', ['{"x": "bar"}'])
|
|
self.assertSequenceEqual(
|
|
JSONModel.objects.filter(field__foo=KeyTransform('x', expr)),
|
|
[self.objs[-1]],
|
|
)
|
|
|
|
def test_key_transform_expression(self):
|
|
self.assertSequenceEqual(
|
|
JSONModel.objects.filter(field__d__0__isnull=False).annotate(
|
|
key=KeyTransform('d', 'field'),
|
|
).annotate(
|
|
chain=KeyTransform('0', 'key'),
|
|
expr=KeyTransform('0', Cast('key', JSONField())),
|
|
).filter(chain=F('expr')),
|
|
[self.objs[8]],
|
|
)
|
|
|
|
def test_isnull_key(self):
|
|
# key__isnull works the same as has_key='key'.
|
|
self.assertSequenceEqual(
|
|
JSONModel.objects.filter(field__a__isnull=True),
|
|
self.objs[:7] + self.objs[9:]
|
|
)
|
|
self.assertSequenceEqual(
|
|
JSONModel.objects.filter(field__a__isnull=False),
|
|
[self.objs[7], self.objs[8]]
|
|
)
|
|
|
|
def test_contains(self):
|
|
self.assertSequenceEqual(
|
|
JSONModel.objects.filter(field__contains={'a': 'b'}),
|
|
[self.objs[7], self.objs[8]]
|
|
)
|
|
|
|
def test_contained_by(self):
|
|
self.assertSequenceEqual(
|
|
JSONModel.objects.filter(field__contained_by={'a': 'b', 'c': 1, 'h': True}),
|
|
[self.objs[6], self.objs[7]]
|
|
)
|
|
|
|
def test_has_key(self):
|
|
self.assertSequenceEqual(
|
|
JSONModel.objects.filter(field__has_key='a'),
|
|
[self.objs[7], self.objs[8]]
|
|
)
|
|
|
|
def test_has_keys(self):
|
|
self.assertSequenceEqual(
|
|
JSONModel.objects.filter(field__has_keys=['a', 'c', 'h']),
|
|
[self.objs[8]]
|
|
)
|
|
|
|
def test_has_any_keys(self):
|
|
self.assertSequenceEqual(
|
|
JSONModel.objects.filter(field__has_any_keys=['c', 'l']),
|
|
[self.objs[7], self.objs[8], self.objs[10]]
|
|
)
|
|
|
|
def test_shallow_list_lookup(self):
|
|
self.assertSequenceEqual(
|
|
JSONModel.objects.filter(field__0=1),
|
|
[self.objs[9]]
|
|
)
|
|
|
|
def test_shallow_obj_lookup(self):
|
|
self.assertSequenceEqual(
|
|
JSONModel.objects.filter(field__a='b'),
|
|
[self.objs[7], self.objs[8]]
|
|
)
|
|
|
|
def test_deep_lookup_objs(self):
|
|
self.assertSequenceEqual(
|
|
JSONModel.objects.filter(field__k__l='m'),
|
|
[self.objs[8]]
|
|
)
|
|
|
|
def test_shallow_lookup_obj_target(self):
|
|
self.assertSequenceEqual(
|
|
JSONModel.objects.filter(field__k={'l': 'm'}),
|
|
[self.objs[8]]
|
|
)
|
|
|
|
def test_deep_lookup_array(self):
|
|
self.assertSequenceEqual(
|
|
JSONModel.objects.filter(field__1__0=2),
|
|
[self.objs[9]]
|
|
)
|
|
|
|
def test_deep_lookup_mixed(self):
|
|
self.assertSequenceEqual(
|
|
JSONModel.objects.filter(field__d__1__f='g'),
|
|
[self.objs[8]]
|
|
)
|
|
|
|
def test_deep_lookup_transform(self):
|
|
self.assertSequenceEqual(
|
|
JSONModel.objects.filter(field__c__gt=1),
|
|
[]
|
|
)
|
|
self.assertSequenceEqual(
|
|
JSONModel.objects.filter(field__c__lt=5),
|
|
[self.objs[7], self.objs[8]]
|
|
)
|
|
|
|
def test_usage_in_subquery(self):
|
|
self.assertSequenceEqual(
|
|
JSONModel.objects.filter(id__in=JSONModel.objects.filter(field__c=1)),
|
|
self.objs[7:9]
|
|
)
|
|
|
|
def test_iexact(self):
|
|
self.assertTrue(JSONModel.objects.filter(field__foo__iexact='BaR').exists())
|
|
self.assertFalse(JSONModel.objects.filter(field__foo__iexact='"BaR"').exists())
|
|
|
|
def test_icontains(self):
|
|
self.assertFalse(JSONModel.objects.filter(field__foo__icontains='"bar"').exists())
|
|
|
|
def test_startswith(self):
|
|
self.assertTrue(JSONModel.objects.filter(field__foo__startswith='b').exists())
|
|
|
|
def test_istartswith(self):
|
|
self.assertTrue(JSONModel.objects.filter(field__foo__istartswith='B').exists())
|
|
|
|
def test_endswith(self):
|
|
self.assertTrue(JSONModel.objects.filter(field__foo__endswith='r').exists())
|
|
|
|
def test_iendswith(self):
|
|
self.assertTrue(JSONModel.objects.filter(field__foo__iendswith='R').exists())
|
|
|
|
def test_regex(self):
|
|
self.assertTrue(JSONModel.objects.filter(field__foo__regex=r'^bar$').exists())
|
|
|
|
def test_iregex(self):
|
|
self.assertTrue(JSONModel.objects.filter(field__foo__iregex=r'^bAr$').exists())
|
|
|
|
def test_key_sql_injection(self):
|
|
with CaptureQueriesContext(connection) as queries:
|
|
self.assertFalse(
|
|
JSONModel.objects.filter(**{
|
|
"""field__test' = '"a"') OR 1 = 1 OR ('d""": 'x',
|
|
}).exists()
|
|
)
|
|
self.assertIn(
|
|
"""."field" -> 'test'' = ''"a"'') OR 1 = 1 OR (''d') = '"x"' """,
|
|
queries[0]['sql'],
|
|
)
|
|
|
|
|
|
@skipUnlessDBFeature('has_jsonb_datatype')
|
|
class TestSerialization(PostgreSQLTestCase):
|
|
test_data = (
|
|
'[{"fields": {"field": {"a": "b", "c": null}, "field_custom": null}, '
|
|
'"model": "postgres_tests.jsonmodel", "pk": null}]'
|
|
)
|
|
|
|
def test_dumping(self):
|
|
instance = JSONModel(field={'a': 'b', 'c': None})
|
|
data = serializers.serialize('json', [instance])
|
|
self.assertJSONEqual(data, self.test_data)
|
|
|
|
def test_loading(self):
|
|
instance = list(serializers.deserialize('json', self.test_data))[0].object
|
|
self.assertEqual(instance.field, {'a': 'b', 'c': None})
|
|
|
|
|
|
class TestValidation(PostgreSQLTestCase):
|
|
|
|
def test_not_serializable(self):
|
|
field = JSONField()
|
|
with self.assertRaises(exceptions.ValidationError) as cm:
|
|
field.clean(datetime.timedelta(days=1), None)
|
|
self.assertEqual(cm.exception.code, 'invalid')
|
|
self.assertEqual(cm.exception.message % cm.exception.params, "Value must be valid JSON.")
|
|
|
|
def test_custom_encoder(self):
|
|
with self.assertRaisesMessage(ValueError, "The encoder parameter must be a callable object."):
|
|
field = JSONField(encoder=DjangoJSONEncoder())
|
|
field = JSONField(encoder=DjangoJSONEncoder)
|
|
self.assertEqual(field.clean(datetime.timedelta(days=1), None), datetime.timedelta(days=1))
|
|
|
|
|
|
class TestFormField(PostgreSQLTestCase):
|
|
|
|
def test_valid(self):
|
|
field = forms.JSONField()
|
|
value = field.clean('{"a": "b"}')
|
|
self.assertEqual(value, {'a': 'b'})
|
|
|
|
def test_valid_empty(self):
|
|
field = forms.JSONField(required=False)
|
|
value = field.clean('')
|
|
self.assertIsNone(value)
|
|
|
|
def test_invalid(self):
|
|
field = forms.JSONField()
|
|
with self.assertRaises(exceptions.ValidationError) as cm:
|
|
field.clean('{some badly formed: json}')
|
|
self.assertEqual(cm.exception.messages[0], "'{some badly formed: json}' value must be valid JSON.")
|
|
|
|
def test_formfield(self):
|
|
model_field = JSONField()
|
|
form_field = model_field.formfield()
|
|
self.assertIsInstance(form_field, forms.JSONField)
|
|
|
|
def test_formfield_disabled(self):
|
|
class JsonForm(Form):
|
|
name = CharField()
|
|
jfield = forms.JSONField(disabled=True)
|
|
|
|
form = JsonForm({'name': 'xyz', 'jfield': '["bar"]'}, initial={'jfield': ['foo']})
|
|
self.assertIn('["foo"]</textarea>', form.as_p())
|
|
|
|
def test_prepare_value(self):
|
|
field = forms.JSONField()
|
|
self.assertEqual(field.prepare_value({'a': 'b'}), '{"a": "b"}')
|
|
self.assertEqual(field.prepare_value(None), 'null')
|
|
self.assertEqual(field.prepare_value('foo'), '"foo"')
|
|
|
|
def test_redisplay_wrong_input(self):
|
|
"""
|
|
When displaying a bound form (typically due to invalid input), the form
|
|
should not overquote JSONField inputs.
|
|
"""
|
|
class JsonForm(Form):
|
|
name = CharField(max_length=2)
|
|
jfield = forms.JSONField()
|
|
|
|
# JSONField input is fine, name is too long
|
|
form = JsonForm({'name': 'xyz', 'jfield': '["foo"]'})
|
|
self.assertIn('["foo"]</textarea>', form.as_p())
|
|
|
|
# This time, the JSONField input is wrong
|
|
form = JsonForm({'name': 'xy', 'jfield': '{"foo"}'})
|
|
# Appears once in the textarea and once in the error message
|
|
self.assertEqual(form.as_p().count(escape('{"foo"}')), 2)
|
|
|
|
def test_widget(self):
|
|
"""The default widget of a JSONField is a Textarea."""
|
|
field = forms.JSONField()
|
|
self.assertIsInstance(field.widget, widgets.Textarea)
|
|
|
|
def test_custom_widget_kwarg(self):
|
|
"""The widget can be overridden with a kwarg."""
|
|
field = forms.JSONField(widget=widgets.Input)
|
|
self.assertIsInstance(field.widget, widgets.Input)
|
|
|
|
def test_custom_widget_attribute(self):
|
|
"""The widget can be overridden with an attribute."""
|
|
class CustomJSONField(forms.JSONField):
|
|
widget = widgets.Input
|
|
|
|
field = CustomJSONField()
|
|
self.assertIsInstance(field.widget, widgets.Input)
|
|
|
|
def test_already_converted_value(self):
|
|
field = forms.JSONField(required=False)
|
|
tests = [
|
|
'["a", "b", "c"]', '{"a": 1, "b": 2}', '1', '1.5', '"foo"',
|
|
'true', 'false', 'null',
|
|
]
|
|
for json_string in tests:
|
|
val = field.clean(json_string)
|
|
self.assertEqual(field.clean(val), val)
|