Django/django
11
0
Fork 0
Code Pull Requests Projects Releases Activity
26,860 Commits 26 Branches 382 Tags
Commit Graph

226 Commits

Author SHA1 Message Date
Mariusz Felisiak
82175ead72 Fixed #28293 -- Fixed union(), intersection(), and difference() when combining with an EmptyQuerySet. 
Thanks Jon Dufresne for the report and Tim Graham for the review.
 2017-06-13 08:16:16 +02:00
François Freitag
edee5a8de6 Fixed #27639 -- Added chunk_size parameter to QuerySet.iterator(). 2017-06-01 17:50:41 -04:00
Jon Dufresne
21046e7773 Fixed #28249 -- Removed unnecessary dict.keys() calls. 
iter(dict) is equivalent to iter(dict.keys()).
 2017-05-27 19:08:46 -04:00
Simon Charette
4acae21846 Fixed #24254 -- Fixed queries using the __in lookup with querysets using distinct() and order_by(). 
Thanks Tim for the review.
 2017-05-11 21:50:07 -04:00
Simon Charette
daf2bd3efe Fixed #28107 -- Disabled grouping of selected primary keys for unmanaged models. 
The grouping caused an issue with database views as PostgreSQL's query planer
isn't smart enough to introspect primary keys through views. Django doesn't
support database views but documents that unmanaged models should be used to
query them.

Thanks powderflask for the detailed report and investigation.
 2017-05-11 20:00:57 -04:00
Sergey Fedoseev
e7afef13f5 Fixed #26788 -- Fixed QuerySet.update() crash when updating a geometry to another one. 2017-04-10 13:26:26 -04:00
Mariusz Felisiak
054a44d6f0 Used NotSupportedError instead of DatabaseError in SQLCompiler.as_sql(). 2017-04-10 12:49:27 -04:00
Mariusz Felisiak
695d4dd790 Fixed #23147 -- Disabled a limit/offset on a query with select_for_update on Oracle. 
Thanks Shai Berger and Tim Graham for the reviews.
 2017-04-07 14:08:07 +02:00
Mariusz Felisiak
1d070d027c Fixed #25414 -- Fixed QuerySet.annotate() with pk in values() on MySQL. 
Thanks Tim Graham and Simon Charette for the reviews.
 2017-03-29 06:47:07 +02:00
Anton Samarchyan
60e52a047e Refs #27656 -- Updated django.db docstring verbs according to PEP 257. 2017-02-28 09:17:27 -05:00
chillaranand
d6eaf7c018 Refs #23919 -- Replaced super(ClassName, self) with super(). 2017-01-25 12:23:46 -05:00
Mads Jensen
ebf34c3cdc Removed unused variables that are overwritten. 2017-01-25 09:14:05 -05:00
Tim Graham
d170c63351 Refs #23919 -- Removed misc references to Python 2. 2017-01-21 20:02:00 -05:00
Simon Charette
cecc079168 Refs #23919 -- Stopped inheriting from object to define new style classes. 2017-01-19 08:39:46 +01:00
Claude Paroz
2b281cc35e Refs #23919 -- Removed most of remaining six usage 
Thanks Tim Graham for the review.
 2017-01-18 21:33:28 +01:00
Florian Apolloner
84c1826ded Fixed #27718 -- Added QuerySet.union(), intersection(), difference(). 
Thanks Mariusz Felisiak for review and Oracle assistance.
Thanks Tim Graham for review and writing docs.
 2017-01-14 08:32:07 -05:00
François Freitag
6b6be692fc Refs #16614 -- Prevented database errors from being masked by cursor close. 
When an error occurred during the cursor.execute statement, the cursor
is closed. This operation did not fail with client-side cursors. Now,
with server-side cursors, the close operation might fail (example
below). The original error should be raised, not the one raised by
cursor.close(), this is only clean-up code.

For example, one can attempt to create a named cursor for an invalid
query. psycopg will raise an error about the invalid query and the
server-side cursor will not be created on PostgreSQL. When the code
attempts to cursor.close(), it asks psycopg to close a cursor that was
not created. pyscopg raises a new error: psycopg2.OperationalError:
cursor "_django_curs_140365867840512_20" does not exist.
 2017-01-14 07:13:00 -05:00
François Freitag
f3b7c05936 Refs #16614 -- Made QuerySet.iterator() use server-side cursors on PostgreSQL. 
Thanks to Josh Smeaton for the idea of implementing server-side cursors
in PostgreSQL from the iterator method, and Anssi Kääriäinen and Kevin
Turner for their previous work. Also Simon Charette and Tim Graham for
review.
 2017-01-11 09:25:37 -05:00
Florian Apolloner
00c7bfadf4 Removed unused enumerate. 2016-12-29 14:55:17 +01:00
Daniel Hillier
7da37699e8 Fixed #27594 -- Fixed select_related() with reverse self-referential OneToOneField. 
Fixed definition of `klass_info['from_parent']` so that two models aren't
considered from a parent class if the model classes are the same.
 2016-12-14 07:46:27 -05:00
Tim Graham
1bc249c2a6 Fixed #20939 -- Simplified query generation by converting QuerySet to Query. 
Thanks Anssi Kääriäinen for the initial patch and Anssi, Simon Charette,
and Josh Smeaton for review.
 2016-10-28 11:20:23 -04:00
Tim Graham
df1796b13f Removed unused branch in SQLUpdateCompiler.as_sql(). 
Unknown if it was ever needed.
 2016-10-13 16:56:26 -04:00
Tim Graham
816eae3508 Removed unused EmptyResultSets in SQLCompilers. 
Unused since ed1bcf05158acf4bf4e0189d477b6c762bd0133e.
 2016-10-13 12:12:58 -04:00
François Freitag
8ac115c730 Fixed #27193 -- Preserved ordering in select_for_update subqueries. 2016-10-04 10:46:29 -04:00
Tim Graham
419b6ec7d0 Removed unused branch in SQLCompiler.as_subquery_condition(). 
Unused since dcdc579d162b750ee3449e34efd772703592faca.
 2016-09-27 09:58:53 -04:00
Mikhail Denisenko
bae64dd0f1 Fixed #27062 -- Eased implementing select_for_update() on MSSQL. 2016-09-09 11:57:38 -04:00
Simon Charette
b8e6e1b43b
Fixed #26500 -- Added SKIP LOCKED support to select_for_update(). 
Thanks Tim for the review.
 2016-08-08 12:01:43 -04:00
Johannes Dollinger
46509cf13d Moved EmpytResultSet to django.core.exceptions. 
This removes the need for some inner imports.
 2016-08-08 10:43:34 -04:00
Johannes Dollinger
c002a0d39f Fixed #26517 -- Fixed ExpressionWrapper with empty queryset. 2016-08-08 10:43:33 -04:00
Tim Graham
df8d8d4292 Fixed E128 flake8 warnings in django/. 2016-04-08 09:51:06 -04:00
Tim Graham
359be4460e Refs #19527 -- Fixed SQL compiler regression causing Oracle failure. 2016-03-05 14:02:35 -05:00
acrefoot
04240b2365 Refs #19527 -- Allowed QuerySet.bulk_create() to set the primary key of its objects. 
PostgreSQL support only.

Thanks Vladislav Manchev and alesasnouski for working on the patch.
 2016-03-02 14:29:09 -05:00
Anssi Kääriäinen
ee596888e1 Fixed #26092 -- Fixed QuerySet.order_by() regression with an M2M through model. 2016-01-20 19:13:05 -05:00
Sergey Fedoseev
ed1bcf0515 Refs #25894 -- Fixed evaluation of zero-length slices of QuerySet.values() on Oracle. 2015-12-17 17:07:10 -05:00
Sergey Fedoseev
69b69f6d60 Fixed #25894 -- Fixed evaluation of zero-length slices of QuerySet.values(). 2015-12-15 07:29:35 -05:00
Dmitry Dygalo
92eced62cd Simplified lists creation in three places. 2015-11-17 07:58:49 -05:00
Tim Graham
67732a9b18 Fixed #24687 -- Added select_related() validation for nested non-relational fields. 
The removed test was added in the original select_related() validation
patch (45d4e43d2d25b902e3821b612209afa951a8bcb8), but there doesn't
seem to be any reason for it.

Thanks Claude Paroz for help and review.
 2015-10-10 09:48:50 -04:00
Tim Graham
3f50dc2be5 Removed SQLCompiler.__call__() per deprecation timeline. 2015-09-23 19:31:09 -04:00
Alex Hill
134ca4d438 Fixed #24509 -- Added Expression support to SQLInsertCompiler 2015-09-22 23:35:24 +10:00
Tim Graham
233b46f931 Fixed #19263 -- Fixed crash when filtering using __in and an empty QuerySet. 
Thanks Marcin Biernat for the initial patch and tests.
 2015-09-04 07:44:36 -04:00
Tim Graham
333cbdcd2d Fixed #24951 -- Fixed AssertionError in delete queries involving a foreign/primary key. 
Thanks Anssi Kääriäinen for help.
 2015-08-20 08:14:16 -04:00
Valentina Mukhamedzhanova
1f7b25c1a7 Fixed #24986 -- Added support for annotations in DISTINCT queries. 2015-08-15 08:23:32 -04:00
risicle
5d60d2b457 Adjusted SQLCompiler.get_order_by()'s docstring return value. 2015-07-28 10:49:26 -04:00
Tim Graham
aaacaeb096 Renamed RemovedInDjangoXYWarnings for new roadmap. 
Forwardport of ae1d663b7913f6da233c55409c4973248372d302
from stable/1.8.x plus more.
 2015-06-24 16:08:20 -04:00
Anssi Kääriäinen
adc57632bc Fixed #24748 -- Fixed incorrect GROUP BY on MySQL in some queries 
When the query's model had a self-referential foreign key, the
compiler.get_group_by() code incorrectly used the self-referential
foreign key's column (for example parent_id) as GROUP BY clause
when it should have used the model's primary key column (id).
 2015-05-11 11:42:27 -04:00
Simon Charette
b44ed404c7 Fixed #24654 -- Based ordering circular references detection on columns. 
Thanks to Elmar Bucher for the report and Tim for the review.
 2015-04-20 15:49:58 -04:00
Anssi Kääriäinen
355c5edd93 Fixed #24605 -- Fixed incorrect reference to alias in subquery. 
Thanks to charettes and priidukull for investigating the issue, and to
kurevin for the report.
 2015-04-16 09:22:00 -04:00
Anssi Kääriäinen
fb5c7748da Fixed #24615 -- ordering by expression not part of SELECT 
Fixed queries where an expression was used in order_by() but the
expression wasn't in the query's select clause (for example the
expression could be masked by .values() call)

Thanks to Trac alias MattBlack85 for the report.
 2015-04-16 09:40:47 +02:00
Jay Wineinger
923da0274a Fixed #24611 -- Fixed update() crash with related UUID pk object. 2015-04-13 12:18:24 -04:00
Simon Charette
dc27f3ee0c Fixed #19259 -- Added group by selected primary keys support. 2015-03-29 22:03:30 -04:00