9178 Commits

Author SHA1 Message Date
Amr Anwar
9123fd75ca [2.0.x] Fixed #29229 -- Fixed column mismatch crash when combining two annotated values_list() querysets with union(), difference(), or intersection().
Regression in 7316720603821ebb64dfe8fa592ba6edcef5f3e.

Backport of a0c03c62a8ac586e5be5b21393c925afa581efaf from master
2018-03-19 21:05:59 -04:00
Mattia Procopio
72667bc6ee [2.0.x] Fixed #29206 -- Fixed PasswordResetConfirmView crash when the URL contains a non-UUID where one is expected.
Backport of aeb8c381789ad93866223f8bd07d09ae5e2edd9e from master
2018-03-15 21:42:47 -04:00
Artem Tabolin
9bf8664bfd [2.0.x] Fixed #29221 -- Corrected admin's autocomplete widget to add a space after custom classes.
Backport of a2f7433adc610cb0a85b3e23a1fec2267591f866 from master
2018-03-15 10:56:06 -04:00
dzhuang
59f39ccad8 [2.0.x] Fixed #29213 -- Fixed autocomplete widget's translations for zh-hans/zh-hant.
Backport of e17088a108e604cad23b000a83189fdd02a8a2f9 from master
2018-03-13 11:09:31 -04:00
Simon Charette
0fd21febe7 [2.0.x] Fixed #29195 -- Fixed Exists.output_field resolution on single-valued queries.
The Subquery class which Exists inherits from defaulted to using single-valued
querie's field if no output_field was explicitly specified on initialization
which was bypassing the Exists.output_field defined at the class level.

Moving Subquery's dynamic output_field resolution to _resolve_output_field
should make sure the fallback logic is only performed if required.

Regression in 08654a99bbdd09049d682ae57cc94241534b29f0.

Thanks Oli Warner for the detailed report.

Backport of 277ed072094ad87fc6b2c4669f21d43b1f39043c from master
2018-03-08 14:06:10 -05:00
Tim Graham
94c5da1d17 [2.0.x] Fixed CVE-2018-7537 -- Fixed catastrophic backtracking in django.utils.text.Truncator.
Thanks James Davis for suggesting the fix.
2018-03-06 08:52:23 -05:00
Tim Graham
e157315da3 [2.0.x] Fixed CVE-2018-7536 -- Fixed catastrophic backtracking in urlize and urlizetrunc template filters.
Thanks Florian Apolloner for assisting with the patch.
2018-03-06 08:52:23 -05:00
Christophe Mehay
e91ff6e29c [2.0.x] Fixed #29176 -- Fixed AbstractBaseUser.normalize_username() crash if username isn't a string.
Backport of 40bac28faabbacd0875e59455cd80fb1dbb16966 from master
2018-03-02 11:48:43 -05:00
Tomáš Ehrlich
3cdc88ba53 [2.0.x] Fixed #29172 -- Fixed crash with Window expression in a subquery.
Backport of fa352626c2a80bcdcd0fc6492b5fd5130490f05e from master
2018-03-01 10:51:54 -05:00
Mariusz Felisiak
10a20e4b37
[2.0.x] Fixed #29166 -- Fixed crash in When() expression with a list argument.
Thanks Matthew Pava for the report and Tim Graham and Carlton Gibson for
reviews.
Regression in 19b2dfd1bfe7fd716dd3d8bfa5f972070d83b42f.

Backport of 54f80430be4a9adf1fc00b4ca17547415fafc69b from master
2018-02-28 18:10:58 +01:00
Tim Graham
0993aee31d [2.0.x] Removed blank lines per isort 4.3.0. 2018-02-20 08:48:55 -05:00
Tim Graham
4b8e433e1c [2.0.x] Fixed #29126 -- Doc'd the behavior of QuerySet.update_or_create() with manually specified pks.
Backport of e917ea6bec45d7f789ca96a13be15df9521963e1 from master
2018-02-15 13:41:33 -05:00
Tim Graham
fd18345e10 [2.0.x] Refs #29125 -- Made Q.deconstruct() omit 'query_utils' in the path and _connector='AND' since it's a default value.
Backport of 9ba3df82402e7e23b353da20aea6894935241ef9 from master
2018-02-12 20:47:58 -05:00
Tim Graham
aeb35548dc [2.0.x] Fixed #29125 -- Made Q.deconstruct() deterministic with multiple keyword arguments.
Backport of b95c49c954e3b75678bb258e9fb2ec30d0d960bb from master
2018-02-12 20:47:51 -05:00
Raphael Gaschignard
9b5ba2168c [2.0.x] Fixed #29118 -- Fixed crash with QuerySet.order_by(Exists(...)).
Backport of bf26f66029bca94b007a2452679ac004598364a6 from master
2018-02-10 19:00:37 -05:00
Manatsawin Hanmongkolchai
a1286b5a64 [2.0.x] Fixed #29109 -- Fixed the admin time picker widget for the Thai locale.
Backport of 1a1264f1494976c562c7cb832fe47f3e1e765b8f from master
2018-02-10 16:06:03 -05:00
Tim Graham
7b20d01a84 [2.0.x] Switched test requirement to new psycopg2-binary package.
Backport of d4373b6da4b420fe9211438addeedb396a3821be from master
2018-02-08 20:22:20 -05:00
Simon Charette
8d03356d35 [2.0.x] Fixed #29108 -- Fixed crash in aggregation of distinct+ordered+sliced querysets.
Regression in 4acae21846f6212aa992763e587c7e201828d7b0.
Thanks Stephen Brooks for the report.

Backport of d61fe246015aa4fdc6dcb837ffb1442fa71ae586 from master
2018-02-08 10:00:12 -05:00
Tim Graham
c37bb28677 [2.0.x] Fixed CVE-2018-6188 -- Fixed information leakage in AuthenticationForm.
Reverted 359370a8b8ca0efe99b1d4630b291ec060b69225 (refs #28645).

This is a security fix.
2018-02-01 09:13:59 -05:00
Tim Graham
1bd45e2458 [2.0.x] Fixed #29094 -- Fixed crash when entering an invalid uuid in ModelAdmin.raw_id_fields.
Regression in 2f9861d823620da7ecb291a8f005f53da12b1e89.

Thanks Carel Burger for the report and fix.

Backport of 552abffab16cbdff571486b683e7e7ef12e46066 from master
2018-02-01 08:46:13 -05:00
Tim Graham
834843ca4f [2.0.x] Fixed #29091 -- Fixed makemigrations crash if migrations directory doesn't have __init__.py.
Regression in aadd3aeb2ba3153e35bd805c80c901f289a6f333.

Backport of 0a37ea56d05208e31ed2f29fdffca65b6d92fa2e from master
2018-01-31 09:37:07 -05:00
Tim Graham
55e16f25e9 [2.0.x] Fixed #29071 -- Fixed contrib.auth.authenticate() crash if a backend doesn't accept a request but a later one does.
Regression in a3ba2662cdaa36183fdfb8a26dfa157e26fca76a.
2018-01-31 08:34:11 -05:00
Tim Graham
14f1c4d435 [2.0.x] Wrapped an import per isort. 2018-01-30 19:54:04 -05:00
Mariusz Felisiak
42622b8934
[2.0.x] Fixed #29054 -- Fixed a regression where a queryset that annotates with geometry objects crashes.
Made GEOSGeometryBase hashable.
Regression in 19b2dfd1bfe7fd716dd3d8bfa5f972070d83b42f.

Thanks Tim Graham for the review.
Backport of b002a032f90b8cd228cfcee6c88cd238a8191cc0 from master
2018-01-27 11:14:42 +01:00
Jon Dufresne
61c74ae74f [2.0.x] Fixed #29067 -- Fixed regression in QuerySet.values_list(..., flat=True) followed by annotate().
Regression in 4dfd6b88d520b43b6363946e5ee58ba14cd1efe6.

Backport of 3187c89d6f8c60ca7e78093d5b37e0709e71cea9 from master
2018-01-26 10:22:14 -05:00
Étienne Loks
8f2e3857ce [2.0.x] Fixed #29016 -- Fixed incorrect foreign key nullification on related instance deletion.
Backport of 9a621edf624a4eb1f1645fca628a9e432f0de776 from master
2018-01-13 13:10:02 -05:00
Tim Graham
26a20e4fba [2.0.x] Fixed a GeoIP2 test failure with the latest GeoIP2 database.
Backport of 66d74676e23c32bc676fb0706af8580b391953b6 from master
2018-01-10 10:13:59 -05:00
Mariusz Felisiak
8f67eeaef4
[2.0.x] Refs #28958 -- Added a test for ModelAdmin with query expressions in ordering.
This provides additional test coverage but isn't a regression test for
the ticket's issue.

Backport of 1d00923848d504c6132019492b8d5a6cdf8261db from master
2017-12-27 19:49:15 +01:00
Mariusz Felisiak
b54302d226
[2.0.x] Fixed #28958 -- Fixed admin changelist crash when using a query expression in the page's ordering.
Thanks Tim Graham for the review.

Backport of c8152137400b5932578cd1788b79560c9772e56b from master
2017-12-27 18:46:05 +01:00
Ran Benita
4e4619a2b8 [2.0.x] Fixed #28944 -- Fixed crash when chaining values()/values_list() after QuerySet.select_for_update(of=()).
Backport of c21f158295d92e35caf96436bfdbbff554fc5569 from master
2017-12-26 12:18:39 -05:00
Claude Paroz
830636df73 [2.0.x] Fixed #28594 -- Removed Jython docs and specific code
Thanks Andrey Martyanov for the report, and Tim Graham for the review.
Backport of 23b21db31bfcf2a065d485617412cca43a311a4c from master.
2017-12-23 10:28:29 +01:00
Simon Charette
b40a1d774d [2.0.x] Fixed #28884 -- Fixed crash on SQLite when renaming a field in a model referenced by a ManyToManyField.
Introspected database constraints instead of relying on _meta.related_objects
to determine whether or not a table or a column is referenced on rename
operations.

This has the side effect of ignoring both db_constraint=False and virtual
fields such as GenericRelation which aren't backend by database level
constraints and thus shouldn't prevent the rename operations from being
performed in a transaction.

Regression in 095c1aaa898bed40568009db836aa8434f1b983d.

Thanks Tim for the additional tests and edits, and Mariusz for the review.

Backport of 9f7772e098439f9edea3d25ab127539fc514eeb2 from master
2017-12-22 16:09:49 -05:00
Tilmann Becker
c99ab335a1 [2.0.x] Fixed #28947 -- Fixed crash when coercing a translatable URL pattern to str.
Regression in df41b5a05d4e00e80e73afe629072e37873e767a.

Backport of 01384ce36c3fddfbcc5af6e1108bdb8cd3e9389d from master
2017-12-20 20:56:57 -05:00
Tim Graham
6f86d8bc69 [2.0.x] Fixed #28941 -- Fixed crash in testserver command startup.
Regression in 2b09e4c88e96cb03b29f5a6b0e4838ab4271e631.

Backport of e7b804c060a1f9fc089cf935801aa85b09db062b from master
2017-12-20 15:15:24 -05:00
Tim Graham
7c939ae6e4 [2.0.x] Refs #28932 -- Skipped the failing test for refs #28915 on Oracle. 2017-12-20 11:59:45 -05:00
Tim Graham
22fc7a6594 [2.0.x] Fixed #25277 -- Restored test dependency to the original python-memcached.
Backport of 770b9ea77fb5e39d616e62b54c06755e6d4f4d36 from master
2017-12-18 15:21:21 -10:00
Sergey Fedoseev
0f7ca1e878 [2.0.x] Fixed #28915 -- Prevented SQLite from truncating trailing zeros in the fractional part of DecimalField.
This reverts commit a146b65628e702a9a3ed5be21542ca45366fbb29 and adds
a test for the regression.

Backport of 6fd6d8383f48ea2fe4e058725fa30529a083e9a5 from master
2017-12-12 22:01:25 -10:00
Rodrigo Pinheiro Marques de Araújo
9f39f202ab [2.0.x] Fixed #28898 -- Corrected admin check to allow a OneToOneField in ModelAdmin.autocomplete_fields.
Backport of 30a389bd7795016d7f48bcda997e5dea5116f9bb from master
2017-12-12 21:40:05 -10:00
Sergey Fedoseev
ce26ec0163 [2.0.x] Fixed #28896 -- Reallowed filtering a queryset with GeometryField=None.
Regression in 58da81a5a372a69f0bac801c412b57f3cce5f188.

Backport of da71e4bb086593b5ca76bf698358d27ead2cfed2 from master
2017-12-12 17:15:29 -10:00
Sergey Fedoseev
a5c6040447 [2.0.x] Refs #27985 -- Reallowed using __exact=None as an alias for __isnull=True if a custom lookup class with lookup_name != None is registered as the exact lookup.
Regression in 58da81a5a372a69f0bac801c412b57f3cce5f188 and prerequisite
for refs #28896.

Backport of 10bfa876be59feec24bb6a40fa11bece808ee405 from master
2017-12-12 17:15:16 -10:00
Morgan Wahl
5ca9cf47a7 [2.0.x] Refs #28856 -- Fixed caching of a GenericForeignKey pointing to a model that uses more than one level of MTI.
Forwardport of 35222035029863f95769e2e59beeeb953d125689 from stable/1.11.x
2017-12-08 14:00:50 -05:00
Tim Graham
a06828cd2e [2.0.x] Reverted "[1.11.x] Refs #28856 -- Fixed caching of a GenericForeignKey pointing to a model that uses more than one level of MTI."
This reverts commit a2aea4521d5e3cf8c76ef17e6edafee1c87bbf0a as it was
committed by mistake.
2017-12-07 09:06:09 -05:00
Morgan Wahl
a2aea4521d [1.11.x] Refs #28856 -- Fixed caching of a GenericForeignKey pointing to a model that uses more than one level of MTI. 2017-12-06 10:08:52 -05:00
Mariusz Felisiak
741711f8a2 [2.0.x] Refs #28876 -- Fixed incorrect foreign key constraint name for models with quoted db_table.
Thanks Simon Charette and Tim Graham for the review and Carlos E. C.
Leite for the report.

Backport of fc48047586a8f92262f55d9d2bfb976325844b23 from master
2017-12-05 22:34:56 +01:00
Mariusz Felisiak
73ab743866 [2.0.x] Refs #28876 -- Fixed incorrect class-based model index name generation for models with quoted db_table.
Thanks Simon Charette and Tim Graham for the review and Carlos E. C.
Leite for the report.

Backport of f79d9a322c6008e5fada1453aebfb56afc316cc8 from master
2017-12-05 22:34:47 +01:00
Nick Pope
c1d57615ac [2.0.x] Fixed #28890 -- Removed newlines between MultiWidget's subwidgets.
Regression in b52c73008a9d67e9ddbb841872dc15cdd3d6ee01.

Backport of e014f91a70aa3ccdddb363a733c76e35597424fa from master
2017-12-05 11:44:11 -05:00
Tim Graham
dbdf5deab0 [2.0.x] Refs #28871 -- Fixed admin_views selenium test failure.
Backport of 7664fe275910bb31fcca2d54844bedde19fc4ed9 from master
2017-12-02 09:59:02 -05:00
Tim Graham
63d425c679 [2.0.x] Fixed #28871 -- Fixed initialization of autocomplete widgets in "Add another" inlines.
Also allowed autocomplete widgets to work on AdminSites with a name other
than 'admin'.

Backport of 81057645f61fe545f4f11737dbd3040043ed2436 from master
2017-12-01 22:18:12 -05:00
Simon Charette
31d318d19c [2.0.x] Fixed #28849 -- Fixed referenced table and column rename on SQLite.
Thanks Ramiro for the input and Tim for the review.

Backport of 095c1aaa898bed40568009db836aa8434f1b983d from master
2017-12-01 22:15:48 -05:00
Tim Graham
50b35eef0b [2.0.x] Used a separate admin site for autocomplete tests.
Backport of 474bd7a5d4b0b47eeedc03ad471ae9e630e95258 from master
2017-12-01 22:05:16 -05:00