Django/django
11
0
Fork 0
Code Pull Requests Projects Releases Activity

[1.11.x] Fixed #31073 -- Prevented CheckboxInput.get_context() from mutating attrs.

Browse Source 
Backport of 02eff7ef60466da108b1a33f1e4dc01eec45c99d from master.
This commit is contained in:
Peter Andersen 2019-12-09 08:54:40 -08:00 committed by Mariusz Felisiak
parent 4f1501660b
commit e8fdf00cc2
3 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
django/forms/widgets.py
View File

@ -508,6 +508,8 @@ class CheckboxInput(Input):
if self.check_test(value):
if attrs is None:
attrs = {}
else:
attrs = attrs.copy()
attrs['checked'] = True
return super(CheckboxInput, self).get_context(name, value, attrs)

5
tests/forms_tests/widget_tests/test_checkboxinput.py
View File

@ -89,3 +89,8 @@ class CheckboxInputTest(WidgetTest):
def test_value_omitted_from_data(self):
self.assertIs(self.widget.value_omitted_from_data({'field': 'value'}, {}, 'field'), False)
self.assertIs(self.widget.value_omitted_from_data({}, {}, 'field'), False)
def test_get_context_does_not_mutate_attrs(self):
attrs = {'checked': False}
self.widget.get_context('name', True, attrs)
self.assertIs(attrs['checked'], False)

11
tests/postgres_tests/test_array.py
View File

@ -826,6 +826,17 @@ class TestSplitFormWidget(PostgreSQLWidgetTestCase):
}
)
def test_checkbox_get_context_attrs(self):
context = SplitArrayWidget(
forms.CheckboxInput(),
size=2,
).get_context('name', [True, False])
self.assertEqual(context['widget']['value'], '[True, False]')
self.assertEqual(
[subwidget['attrs'] for subwidget in context['widget']['subwidgets']],
[{'checked': True}, {}]
)
def test_render(self):
self.check_html(
SplitArrayWidget(forms.TextInput(), size=2), 'array', None,