[1.2.X] Fixed #14027 -- Ensure that reverse() raises an exception when you try to reverse None. Thanks to Alex for the report and patch.
Backport of r13499 from trunk. git-svn-id: http://code.djangoproject.com/svn/django/branches/releases/1.2.X@13500 bcc190cf-cafb-0310-a4f2-bffc1f526a37
This commit is contained in:
parent
5bd352a966
commit
8419b092ae
@ -183,7 +183,8 @@ class RegexURLResolver(object):
|
||||
else:
|
||||
bits = normalize(p_pattern)
|
||||
lookups.appendlist(pattern.callback, (bits, p_pattern))
|
||||
lookups.appendlist(pattern.name, (bits, p_pattern))
|
||||
if pattern.name is not None:
|
||||
lookups.appendlist(pattern.name, (bits, p_pattern))
|
||||
self._reverse_dict = lookups
|
||||
self._namespace_dict = namespaces
|
||||
self._app_dict = apps
|
||||
|
@ -119,6 +119,10 @@ class URLPatternReverse(TestCase):
|
||||
else:
|
||||
self.assertEquals(got, expected)
|
||||
|
||||
def test_reverse_none(self):
|
||||
# Reversing None should raise an error, not return the last un-named view.
|
||||
self.assertRaises(NoReverseMatch, reverse, None)
|
||||
|
||||
class ResolverTests(unittest.TestCase):
|
||||
def test_non_regex(self):
|
||||
"""
|
||||
|
Loading…
x
Reference in New Issue
Block a user