Django/django
11
0
Fork 0
Code Pull Requests Projects Releases Activity

[1.9.x] Refs #25693 -- Added a regression test for to_attr validation on forward m2m.

Browse Source 
Backport of cc8c02fa0fa2119704d1c39ca8509850aef84acc from master
This commit is contained in:
Simon Charette 2015-11-11 00:49:35 -05:00
parent 0d1d30752a
commit 164cbdac7d
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
tests/prefetch_related/tests.py
View File

@ -223,7 +223,18 @@ class PrefetchRelatedTests(TestCase):
self.assertIn('prefetch_related', str(cm.exception)) self.assertIn('prefetch_related', str(cm.exception))
self.assertIn("name", str(cm.exception)) self.assertIn("name", str(cm.exception))
def test_m2m_shadow(self): def test_forward_m2m_to_attr_conflict(self):
msg = 'to_attr=authors conflicts with a field on the Book model.'
authors = Author.objects.all()
with self.assertRaisesMessage(ValueError, msg):
list(Book.objects.prefetch_related(
Prefetch('authors', queryset=authors, to_attr='authors'),
))
# Without the ValueError, an author was deleted due to the implicit
# save of the relation assignment.
self.assertEqual(self.book1.authors.count(), 3)
def test_reverse_m2m_to_attr_conflict(self):
msg = 'to_attr=books conflicts with a field on the Author model.' msg = 'to_attr=books conflicts with a field on the Author model.'
poems = Book.objects.filter(title='Poems') poems = Book.objects.filter(title='Poems')
with self.assertRaisesMessage(ValueError, msg): with self.assertRaisesMessage(ValueError, msg):