Django/django
11
0
Fork 0
Code Pull Requests Projects Releases Activity

[1.2.X] Fixed some bugs with formtools tests.

Browse Source 
Without these checks, it is possible for the tests to pass by virtue of
asserts never being reached for some reason (very possible in this case, due
to handling of security hashes).

Backport of [15198] from trunk.

git-svn-id: http://code.djangoproject.com/svn/django/branches/releases/1.2.X@15200 bcc190cf-cafb-0310-a4f2-bffc1f526a37
This commit is contained in:
Luke Plant 2011-01-13 23:25:23 +00:00
parent 444bda0be0
commit 0ebb02e9dc
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
django/contrib/formtools/tests.py
View File

@ -247,6 +247,7 @@ class WizardTests(TestCase):
Regression test for ticket #15075. Allow modifying wizard's form_list Regression test for ticket #15075. Allow modifying wizard's form_list
in process_step. in process_step.
""" """
reached = [False]
that = self that = self
class WizardWithProcessStep(WizardClass): class WizardWithProcessStep(WizardClass):
@ -255,6 +256,7 @@ class WizardTests(TestCase):
self.form_list[1] = WizardPageTwoAlternativeForm self.form_list[1] = WizardPageTwoAlternativeForm
if step == 1: if step == 1:
that.assertTrue(isinstance(form, WizardPageTwoAlternativeForm)) that.assertTrue(isinstance(form, WizardPageTwoAlternativeForm))
reached[0] = True
wizard = WizardWithProcessStep([WizardPageOneForm, wizard = WizardWithProcessStep([WizardPageOneForm,
WizardPageTwoForm, WizardPageTwoForm,
@ -264,3 +266,4 @@ class WizardTests(TestCase):
"hash_0": "2fdbefd4c0cad51509478fbacddf8b13", "hash_0": "2fdbefd4c0cad51509478fbacddf8b13",
"wizard_step": "1"} "wizard_step": "1"}
wizard(DummyRequest(POST=data)) wizard(DummyRequest(POST=data))
self.assertTrue(reached[0])